BiteTheDDDDt commented on code in PR #17300:
URL: https://github.com/apache/doris/pull/17300#discussion_r1122563462
##########
be/src/vec/functions/cast_type_to_either.h:
##########
@@ -27,7 +27,7 @@ namespace doris::vectorized {
class IDataType;
template <typename... Ts, typename F>
-static bool cast_type_to_either(const IDataType* type, F&& f) {
+inline bool cast_type_to_either(const IDataType* type, F&& f) {
Review Comment:
```
inline marks the symbol WEAK, which hints linker to choose arbitary one of
definition in object files
static marks the symbol LOCAL, which restricts the symbol in current
translation unit, and the linker may keep multiple instances of (possibly
different) definition.
```
https://gist.github.com/htfy96/50308afc11678d2e3766a36aa60d5f75
A header containing a static function is included by other files, which may
generate an unused-template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
