Gabriel39 commented on PR #66227: URL: https://github.com/apache/doris/pull/66227#issuecomment-5867513982
Fixed the three findings from the latest local review in 6ebb7d5e974: - Historical casts to integer columns now fall back to JNI unless the source is an integer with an identical or narrower width. This includes recursive row, array, and map fields, matched by field ID. - Partial-update default aggregate functions now pass through the same function/type checks as explicit aggregates. Per-field overrides retain precedence; primary keys and sequence-group fields are excluded, including compound sequence groups. - Multi-file primary-key splits now conservatively fall back to JNI, even with known zero deletes and a small read.batch-size. This avoids the pinned Rust merger's retention of consumed losing batches. Eligible single-file primary-key splits and append-only multi-file reads remain available to Rust. This is a routing safeguard, not an upstream merge-memory implementation change. Added independent routing checks and real persisted Parquet fixtures for numeric narrowing, partial-update default decimal/integer aggregates, safe overrides, and three overlapping INSERT-only runs with 1,025 keys and wide values. Extended the SQL regression suite with JNI/Rust profile assertions. Validation: - All three new routing regressions failed against the previous implementation with the expected wrong-reader assertions; the new persisted reproducers also failed before the fix. - After the fix, all 85 JUnit tests passed: 75 PaimonScanNodeTest tests and 10 PaimonRustReaderCompatibilityTest tests, using the FE test classpath built by the repository test runner. - FE reactor Checkstyle, Groovy syntax parsing, and git diff --check passed. - Full external SQL regression and native compilation were not run locally. CI compilation and review have been requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
