Gabriel39 commented on PR #66227: URL: https://github.com/apache/doris/pull/66227#issuecomment-5866087975
Addressed the seven compatibility/resource findings and the routing-test coverage gap in 29b8a78b8d4. The FE now retains JNI for nested projections pruned below a root column, historical integer narrowing (including nested fields matched by ID), primary-key splits with positive or unknown retract counts, unsupported aggregate function/type combinations, integer SUM/PRODUCT, and compact-decimal SUM. This avoids the pinned Rust reader's incorrect results, merge failures, and retained-batch growth across deleted-key prefixes. Compatible scans, including floating-point SUM, remain Rust-eligible. Historical schema compatibility is cached per scan node. Regression coverage includes: - Complete eligible routing fixtures, with each negative case changing the condition under test; nested projection/evolution, default aggregate overrides, and unknown metadata are covered. - Real local Parquet files committed separately without compaction: Java integer wrapping at all four widths, decimal `99 + 1 - 1 = 99`, `collect`, DELETE/UPDATE_BEFORE, and zero/sparse-output merges. - A new external P0 SQL suite that checks explicit expected results, JNI/enabled-reader equivalence, and actual reader profiles. Validation: **78 FE tests passed**, FE Checkstyle passed, and the Groovy suite parsed successfully. Bypassing the new compatibility gate caused all six persisted-file tests to fail; removing each of five existing routing gates also caused its targeted test to fail. The full Doris/object-storage SQL suite was not executed locally. The dependency pin is unchanged; its separate master integration remains #68546. Posted `run buildall` followed by `/review` for this update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
