yiguolei commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4056127330


##########
be/src/exec/sink/writer/iceberg/partition_transformers.h:
##########
@@ -640,6 +679,7 @@ class DateBucketPartitionColumnTransform : public 
PartitionColumnTransform {
     DataTypePtr _target_type;
 };
 
+template <PrimitiveType P = TYPE_DATETIMEV2>

Review Comment:
   不要写默认值了,都让调用的地方显示传递吧



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to