yiguolei commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4056126873
##########
be/src/exec/sink/writer/iceberg/partition_transformers.h:
##########
@@ -89,13 +94,14 @@ class PartitionColumnTransformUtils {
}
static std::string human_hour(int hour_ordinal) {
- int day_value = hour_ordinal / 24;
- int housr_value = hour_ordinal % 24;
+ // Iceberg ordinals floor toward negative infinity, including the hour
before the epoch.
+ int day_value = hour_ordinal / 24 - (hour_ordinal % 24 < 0);
Review Comment:
这种特殊值，都有单测覆盖吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
