yiguolei commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4056098743


##########
be/src/exec/sink/writer/iceberg/partition_transformers.cpp:
##########
@@ -115,10 +118,12 @@ std::unique_ptr<PartitionColumnTransform> 
PartitionColumnTransforms::create(
                 return 
std::make_unique<DateBucketPartitionColumnTransform>(source_type,
                                                                             
parsed_width);
             }
-            case TYPE_DATETIMEV2: {
-                return 
std::make_unique<TimestampBucketPartitionColumnTransform>(source_type,
-                                                                               
  parsed_width);
-            }
+            case TYPE_TIMESTAMPTZ:
+                return 
std::make_unique<TimestampBucketPartitionColumnTransform<TYPE_TIMESTAMPTZ>>(
+                        source_type, parsed_width);
+            case TYPE_DATETIMEV2:
+                return 
std::make_unique<TimestampBucketPartitionColumnTransform<>>(source_type,

Review Comment:
   这里为什么不传递模板参数?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to