github-actions[bot] commented on code in PR #16258:
URL: https://github.com/apache/doris/pull/16258#discussion_r1091855188
##########
be/src/olap/tablet.cpp:
##########
@@ -1691,6 +1767,8 @@ Status Tablet::_cooldown_data() {
TabletMetaPB remote_tablet_meta_pb;
_tablet_meta->to_meta_pb(true, &remote_tablet_meta_pb);
new_rowset_meta->to_rowset_pb(remote_tablet_meta_pb.add_rs_metas());
+ // reset tablet_meta_id
+ remote_tablet_meta_pb.set_tablet_meta_id(UniqueId::gen_uid().to_proto());
Review Comment:
warning: no member named 'set_tablet_meta_id' in 'doris::TabletMetaPB'
[clang-diagnostic-error]
```cpp
));
^
```
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -714,6 +727,12 @@
}
// put to_add rowsets in _rs_metas.
_rs_metas.insert(_rs_metas.end(), to_add.begin(), to_add.end());
+ for (auto& rs_meta : to_add) {
+ if (!rs_meta->is_local() && rs_meta->end_version() >
_cooldowned_version) {
+ _cooldowned_version = it.end_version();
Review Comment:
warning: use of undeclared identifier 'it' [clang-diagnostic-error]
```cpp
_cooldowned_version = it.end_version();
^
```
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -673,6 +683,9 @@ Status TabletMeta::add_rs_meta(const RowsetMetaSharedPtr&
rs_meta) {
}
}
_rs_metas.push_back(rs_meta);
+ if (!rs_meta->is_local() && rs_meta->end_version() > _cooldowned_version) {
+ _cooldowned_version = it.end_version();
Review Comment:
warning: use of undeclared identifier 'it' [clang-diagnostic-error]
```cpp
_cooldowned_version = it.end_version();
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
