github-actions[bot] commented on code in PR #16290:
URL: https://github.com/apache/doris/pull/16290#discussion_r1092790221


##########
be/src/vec/aggregate_functions/aggregate_function_sort.h:
##########
@@ -34,7 +34,7 @@ struct AggregateFunctionSortData {
     Block block;
 
     // The construct only support the template compiler, useless
-    AggregateFunctionSortData() {};
+    AggregateFunctionSortData() = default;

Review Comment:
   warning: explicitly defaulted default constructor is implicitly deleted 
[clang-diagnostic-defaulted-function-deleted]
   ```cpp
       AggregateFunctionSortData() = default;
       ^
   ```
   **be/src/vec/aggregate_functions/aggregate_function_sort.h:32:** default 
constructor of 'AggregateFunctionSortData' is implicitly deleted because field 
'sort_desc' of const-qualified type 'const doris::vectorized::SortDescription' 
(aka 'const vector<doris::vectorized::SortColumnDescription>') would not be 
initialized
   ```cpp
       const SortDescription sort_desc;
                             ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to