github-actions[bot] commented on code in PR #16290:
URL: https://github.com/apache/doris/pull/16290#discussion_r1091729563
##########
be/test/testutil/mock_rowset.h:
##########
@@ -23,36 +23,34 @@
namespace doris {
class MockRowset : public Rowset {
- virtual Status create_reader(std::shared_ptr<RowsetReader>* result)
override {
+ Status create_reader(std::shared_ptr<RowsetReader>* result) override {
return Status::NotSupported("MockRowset not support this method.");
}
- virtual Status remove() override {
- return Status::NotSupported("MockRowset not support this method.");
- }
+ Status remove() override { return Status::NotSupported("MockRowset not
support this method."); }
- virtual Status link_files_to(const std::string& dir, RowsetId
new_rowset_id,
- size_t start_seg_id) override {
+ Status link_files_to(const std::string& dir, RowsetId new_rowset_id,
+ size_t start_seg_id) override {
return Status::NotSupported("MockRowset not support this method.");
}
- virtual Status copy_files_to(const std::string& dir, const RowsetId&
new_rowset_id) override {
+ Status copy_files_to(const std::string& dir, const RowsetId&
new_rowset_id) override {
return Status::NotSupported("MockRowset not support this method.");
}
- virtual Status remove_old_files(std::vector<std::string>* files_to_remove)
override {
+ Status remove_old_files(std::vector<std::string>* files_to_remove)
override {
return Status::NotSupported("MockRowset not support this method.");
}
- virtual bool check_path(const std::string& path) override {
+ bool check_path(const std::string& path) override {
return Status::NotSupported("MockRowset not support this method.");
}
- virtual bool check_file_exist() override {
+ bool check_file_exist() override {
return Status::NotSupported("MockRowset not support this method.");
}
- virtual Status get_segments_key_bounds(std::vector<KeyBoundsPB>*
segments_key_bounds) override {
+ Status get_segments_key_bounds(std::vector<KeyBoundsPB>*
segments_key_bounds) override {
Review Comment:
warning: method 'get_segments_key_bounds' can be made const
[readability-make-member-function-const]
```suggestion
Status get_segments_key_bounds(std::vector<KeyBoundsPB>*
segments_key_bounds) const override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
