github-actions[bot] commented on code in PR #16290:
URL: https://github.com/apache/doris/pull/16290#discussion_r1091696331
##########
be/src/agent/utils.h:
##########
@@ -29,7 +29,7 @@ namespace doris {
class MasterServerClient {
public:
MasterServerClient(const TMasterInfo& master_info,
FrontendServiceClientCache* client_cache);
- virtual ~MasterServerClient() {};
+ virtual ~MasterServerClient() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
virtual ~MasterServerClient() = default;
```
##########
be/src/agent/utils.h:
##########
@@ -59,8 +59,8 @@
class AgentUtils {
public:
- AgentUtils() {};
- virtual ~AgentUtils() {};
+ AgentUtils() {}
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
AgentUtils() = default;
```
##########
be/src/http/action/health_action.h:
##########
@@ -28,7 +28,7 @@ class HealthAction : public HttpHandler {
public:
HealthAction();
- virtual ~HealthAction() {};
+ virtual ~HealthAction() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
virtual ~HealthAction() = default;
```
##########
be/src/http/action/health_action.h:
##########
@@ -28,7 +28,7 @@
public:
HealthAction();
- virtual ~HealthAction() {};
+ virtual ~HealthAction() {}
Review Comment:
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
```suggestion
~HealthAction() override {}
```
##########
be/src/http/action/stream_load_2pc.h:
##########
@@ -29,7 +29,7 @@
public:
StreamLoad2PCAction(ExecEnv* exec_env);
- virtual ~StreamLoad2PCAction() {};
+ virtual ~StreamLoad2PCAction() {}
Review Comment:
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
```suggestion
~StreamLoad2PCAction() override {}
```
##########
be/src/runtime/result_writer.h:
##########
@@ -33,9 +33,9 @@ class Block;
// abstract class of the result writer
class ResultWriter {
public:
- ResultWriter() {};
- ResultWriter(bool output_object_data) :
_output_object_data(output_object_data) {};
- ~ResultWriter() {};
+ ResultWriter() {}
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
ResultWriter() = default;
```
##########
be/src/agent/utils.h:
##########
@@ -59,8 +59,8 @@
class AgentUtils {
public:
- AgentUtils() {};
- virtual ~AgentUtils() {};
+ AgentUtils() {}
+ virtual ~AgentUtils() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
virtual ~AgentUtils() = default;
```
##########
be/src/http/action/stream_load_2pc.h:
##########
@@ -29,7 +29,7 @@ class StreamLoad2PCAction : public HttpHandler {
public:
StreamLoad2PCAction(ExecEnv* exec_env);
- virtual ~StreamLoad2PCAction() {};
+ virtual ~StreamLoad2PCAction() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
virtual ~StreamLoad2PCAction() = default;
```
##########
be/src/runtime/result_writer.h:
##########
@@ -33,9 +33,9 @@
// abstract class of the result writer
class ResultWriter {
public:
- ResultWriter() {};
- ResultWriter(bool output_object_data) :
_output_object_data(output_object_data) {};
- ~ResultWriter() {};
+ ResultWriter() {}
+ ResultWriter(bool output_object_data) :
_output_object_data(output_object_data) {}
+ ~ResultWriter() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
~ResultWriter() = default;
```
##########
be/src/http/action/version_action.h:
##########
@@ -29,7 +29,7 @@ class VersionAction : public HttpHandler {
public:
VersionAction();
- virtual ~VersionAction() {};
+ virtual ~VersionAction() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
virtual ~VersionAction() = default;
```
##########
be/src/http/action/version_action.h:
##########
@@ -29,7 +29,7 @@
public:
VersionAction();
- virtual ~VersionAction() {};
+ virtual ~VersionAction() {}
Review Comment:
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
```suggestion
~VersionAction() override {}
```
##########
be/src/vec/aggregate_functions/aggregate_function_sort.h:
##########
@@ -34,7 +34,7 @@ struct AggregateFunctionSortData {
Block block;
// The construct only support the template compiler, useless
- AggregateFunctionSortData() {};
+ AggregateFunctionSortData() {}
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
AggregateFunctionSortData() = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
