yiguolei commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3772140659
##########
be/src/storage/delete/delete_handler.cpp:
##########
@@ -523,8 +524,9 @@ DeleteHandler::ConditionParseResult
DeleteHandler::parse_condition(
template <typename SubPredType>
requires(std::is_same_v<SubPredType, DeleteSubPredicatePB> or
std::is_same_v<SubPredType, std::string>)
-Status DeleteHandler::_parse_column_pred(TabletSchemaSPtr complete_schema,
- TabletSchemaSPtr
delete_pred_related_schema,
+Status DeleteHandler::_parse_column_pred(const ReadSchema& read_schema,
+ std::vector<TabletColumn>&
dropped_columns,
Review Comment:
一般是把返回值放在最后，并且类型是指针
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
