yiguolei commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3765655641
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -3249,31 +3038,25 @@ void SegmentIterator::_output_index_result_column(const
VExprContextSPtrs& expr_
}
void SegmentIterator::_convert_dict_code_for_predicate_if_necessary() {
- for (auto predicate : _short_cir_eval_predicate) {
- _convert_dict_code_for_predicate_if_necessary_impl(predicate);
- }
-
- for (auto predicate : _pre_eval_block_predicate) {
- _convert_dict_code_for_predicate_if_necessary_impl(predicate);
- }
-
- for (auto column_id : _delete_range_column_ids) {
-
_current_return_columns[column_id].get()->convert_dict_codes_if_necessary();
+ for (const auto& predicate : _col_predicates) {
+ _convert_dict_code_for_predicate_if_necessary_impl(*predicate);
}
- for (auto column_id : _delete_bloom_filter_column_ids) {
-
_current_return_columns[column_id].get()->initialize_hash_values_for_runtime_filter();
+ std::set<std::shared_ptr<const ColumnPredicate>> delete_predicates;
+
_opts.delete_condition_predicates->get_all_column_predicate(delete_predicates);
+ for (const auto& predicate : delete_predicates) {
+ _convert_dict_code_for_predicate_if_necessary_impl(*predicate);
Review Comment:
_col_predicates 里不包括 delete 吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
