csun5285 commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3765667360
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -2949,38 +2727,33 @@ Status SegmentIterator::_next_batch_internal(Block*
block) {
_selected_size);
if (_selected_size > 0) {
// step 3.1: output short circuit and predicate column
- // when lazy materialization enables, _predicate_column_ids =
distinct(_short_cir_pred_column_ids + _vec_pred_column_ids)
- // see _vec_init_lazy_materialization
- // todo(wb) need to tell input columnids from output columnids
- RETURN_IF_ERROR(_output_column_by_sel_idx(block,
_predicate_column_ids,
+ RETURN_IF_ERROR(_output_column_by_sel_idx(block,
_predicate_ordinals,
_sel_rowid_idx.data(), _selected_size));
// step 3.2: read remaining expr column and evaluate it.
if (_is_need_expr_eval) {
// The predicate column contains the remaining expr
column, no need second read.
- if (_common_expr_column_ids.size() > 0) {
+ if (!_common_expr_ordinals.empty()) {
SCOPED_RAW_TIMER(&_opts.stats->non_predicate_read_ns);
RETURN_IF_ERROR(_read_columns_by_rowids(
Review Comment:
已经在前面 pred 的时候读过，放到 block 里面了，这里的 _common_expr_ordinals 是不包含的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
