csun5285 commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3747494405
##########
be/src/storage/delete/delete_handler.h:
##########
@@ -100,19 +101,22 @@ class DeleteHandler {
DeleteHandler() = default;
~DeleteHandler();
- // Initialize DeleteHandler, use the delete conditions of this tablet
whose version less than or equal to
- // 'version' to fill '_del_conds'.
+ // Initialize DeleteHandler, use the delete conditions whose version is
less
+ // than or equal to 'version' to fill '_del_conds'.
+ //
+ // Delete-condition columns that are absent from `read_schema` are resolved
+ // against the schema stored in the corresponding delete-predicate rowset
and
+ // appended to `read_schema` as storage-only columns.
// NOTE: You should lock the tablet's header file before calling this
function.
- // input:
- // * schema: tablet's schema, the delete conditions and data rows are
in this schema
+ // input/output:
+ // * read_schema: its visible prefix is preserved and missing delete
+ // columns are appended as a storage-only suffix
// * version: maximum version
- // * with_sub_pred_v2: whether to use delete sub predicate v2 (v2 is
based on PB and use column uid to specify a column,
- // v1 is based on condition string, and relies on regex for parse)
// return:
// * Status::Error<DELETE_INVALID_PARAMETERS>(): input parameters are
not valid
// * Status::Error<MEM_ALLOC_FAILED>(): alloc memory failed
- Status init(TabletSchemaSPtr tablet_schema,
- const std::vector<RowsetMetaSharedPtr>& delete_preds, int64_t
version);
+ Status init(ReadSchemaSPtr& read_schema, const
std::vector<RowsetMetaSharedPtr>& delete_preds,
Review Comment:
可以
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
