csun5285 commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3747595898


##########
be/src/exprs/function_filter.h:
##########
@@ -25,15 +25,15 @@ namespace doris {
 
 class FunctionFilter {
 public:
-    FunctionFilter(bool opposite, const std::string& col_name, 
doris::FunctionContext* fn_ctx,
+    FunctionFilter(bool opposite, uint32_t column_id, doris::FunctionContext* 
fn_ctx,

Review Comment:
   未找到的话返回 -1 



##########
be/src/exec/scan/olap_scanner.cpp:
##########
@@ -114,19 +113,18 @@ OlapScanner::OlapScanner(ScanLocalStateBase* parent, 
OlapScanner::Params&& param
     _vector_search_params = params.state->get_vector_search_params();
 }
 
-static std::string read_columns_to_string(TabletSchemaSPtr tablet_schema,
-                                          const std::vector<uint32_t>& 
read_columns) {
+static std::string read_columns_to_string(const ReadSchema& read_schema) {

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to