yiguolei commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3747487543
##########
be/src/storage/delete/delete_handler.h:
##########
@@ -100,19 +101,22 @@ class DeleteHandler {
DeleteHandler() = default;
~DeleteHandler();
- // Initialize DeleteHandler, use the delete conditions of this tablet
whose version less than or equal to
- // 'version' to fill '_del_conds'.
+ // Initialize DeleteHandler, use the delete conditions whose version is
less
+ // than or equal to 'version' to fill '_del_conds'.
+ //
+ // Delete-condition columns that are absent from `read_schema` are resolved
+ // against the schema stored in the corresponding delete-predicate rowset
and
+ // appended to `read_schema` as storage-only columns.
// NOTE: You should lock the tablet's header file before calling this
function.
- // input:
- // * schema: tablet's schema, the delete conditions and data rows are
in this schema
+ // input/output:
+ // * read_schema: its visible prefix is preserved and missing delete
+ // columns are appended as a storage-only suffix
// * version: maximum version
- // * with_sub_pred_v2: whether to use delete sub predicate v2 (v2 is
based on PB and use column uid to specify a column,
- // v1 is based on condition string, and relies on regex for parse)
// return:
// * Status::Error<DELETE_INVALID_PARAMETERS>(): input parameters are
not valid
// * Status::Error<MEM_ALLOC_FAILED>(): alloc memory failed
- Status init(TabletSchemaSPtr tablet_schema,
- const std::vector<RowsetMetaSharedPtr>& delete_preds, int64_t
version);
+ Status init(ReadSchemaSPtr& read_schema, const
std::vector<RowsetMetaSharedPtr>& delete_preds,
Review Comment:
这个接口，我感觉你不要偷偷在在里面修改read_schema的值，这样容易让上层不理解。
我们返回一个result<ReadSchemaSPtr> 可能会好一些，这样，让上层调用的显示的知道，这个api 可能会修改read
schema，他们需要显示的用这个api 返回的read schema，去修改他们已经保存的read schema。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
