github-actions[bot] commented on code in PR #15669:
URL: https://github.com/apache/doris/pull/15669#discussion_r1066692783
##########
be/src/vec/data_types/data_type_struct.h:
##########
@@ -103,6 +106,7 @@ class DataTypeStruct final : public IDataType {
LOG(FATAL) << "serialize not implemented";
}
+ Status from_string(ReadBuffer& rb, IColumn* column) const;
Review Comment:
warning: 'from_string' overrides a member function but is not marked
'override' [clang-diagnostic-inconsistent-missing-override]
```cpp
Status from_string(ReadBuffer& rb, IColumn* column) const;
^
```
**be/src/vec/data_types/data_type.h:72:** overridden virtual function is here
```cpp
virtual Status from_string(ReadBuffer& rb, IColumn* column) const;
^
```
##########
be/src/vec/data_types/data_type_struct.h:
##########
@@ -103,6 +106,7 @@
LOG(FATAL) << "serialize not implemented";
}
+ Status from_string(ReadBuffer& rb, IColumn* column) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
Status from_string(ReadBuffer& rb, IColumn* column) const override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
