github-actions[bot] commented on code in PR #15669:
URL: https://github.com/apache/doris/pull/15669#discussion_r1063051134
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -23,10 +23,10 @@
namespace doris::vectorized {
namespace ErrorCodes {
-extern const int ILLEGAL_COLUMN;
-extern const int NOT_IMPLEMENTED;
-extern const int CANNOT_INSERT_VALUE_OF_DIFFERENT_SIZE_INTO_TUPLE;
-extern const int LOGICAL_ERROR;
+ const int ILLEGAL_COLUMN = 44;
+ const int NOT_IMPLEMENTED = 48;
+ const int LOGICAL_ERROR = 49;
Review Comment:
warning: unused variable 'LOGICAL_ERROR'
[clang-diagnostic-unused-const-variable]
```cpp
const int LOGICAL_ERROR = 49;
^
```
##########
be/src/vec/data_types/data_type_struct.cpp:
##########
@@ -23,14 +23,14 @@
namespace doris::vectorized {
namespace ErrorCodes {
-extern const int BAD_ARGUMENTS;
-extern const int DUPLICATE_COLUMN;
-extern const int EMPTY_DATA_PASSED;
-extern const int NOT_FOUND_COLUMN_IN_BLOCK;
-extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH;
-extern const int SIZES_OF_COLUMNS_IN_TUPLE_DOESNT_MATCH;
-extern const int ILLEGAL_INDEX;
-extern const int LOGICAL_ERROR;
+ const int NOT_FOUND_COLUMN_IN_BLOCK = 10;
+ const int SIZES_OF_COLUMNS_IN_TUPLE_DOESNT_MATCH = 13;
+ const int DUPLICATE_COLUMN = 15;
+ const int BAD_ARGUMENTS = 36;
+ const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH = 42;
+ const int LOGICAL_ERROR = 49;
+ const int EMPTY_DATA_PASSED = 92;
Review Comment:
warning: unused variable 'EMPTY_DATA_PASSED'
[clang-diagnostic-unused-const-variable]
```cpp
const int EMPTY_DATA_PASSED = 92;
^
```
##########
be/src/vec/data_types/data_type_struct.cpp:
##########
@@ -23,14 +23,14 @@
namespace doris::vectorized {
namespace ErrorCodes {
-extern const int BAD_ARGUMENTS;
-extern const int DUPLICATE_COLUMN;
-extern const int EMPTY_DATA_PASSED;
-extern const int NOT_FOUND_COLUMN_IN_BLOCK;
-extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH;
-extern const int SIZES_OF_COLUMNS_IN_TUPLE_DOESNT_MATCH;
-extern const int ILLEGAL_INDEX;
-extern const int LOGICAL_ERROR;
+ const int NOT_FOUND_COLUMN_IN_BLOCK = 10;
+ const int SIZES_OF_COLUMNS_IN_TUPLE_DOESNT_MATCH = 13;
+ const int DUPLICATE_COLUMN = 15;
+ const int BAD_ARGUMENTS = 36;
+ const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH = 42;
+ const int LOGICAL_ERROR = 49;
Review Comment:
warning: unused variable 'LOGICAL_ERROR'
[clang-diagnostic-unused-const-variable]
```cpp
const int LOGICAL_ERROR = 49;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
