yiguolei commented on code in PR #15718:
URL: https://github.com/apache/doris/pull/15718#discussion_r1067785866
##########
be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:
##########
@@ -97,80 +82,127 @@ Status SchemaRowsetsScanner::get_all_rowsets() {
return Status::OK();
}
-Status SchemaRowsetsScanner::fill_one_row(Tuple* tuple, MemPool* pool) {
- // set all bit to not null
- memset((void*)tuple, 0, _tuple_desc->num_null_bytes());
- RowsetSharedPtr rowset = rowsets_[rowsets_idx_];
+Status SchemaRowsetsScanner::get_next_block(vectorized::Block* block, bool*
eos) {
+ if (!_is_init) {
+ return Status::InternalError("Used before initialized.");
+ }
+ if (nullptr == block || nullptr == eos) {
+ return Status::InternalError("input pointer is nullptr.");
+ }
+
+ *eos = true;
Review Comment:
rowsets 这个表不一定可以一个block 一下子装进去的，可能有10000000个rowset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
