github-actions[bot] commented on code in PR #15718:
URL: https://github.com/apache/doris/pull/15718#discussion_r1066619623
##########
be/src/exec/schema_scanner/schema_files_scanner.h:
##########
@@ -28,7 +28,7 @@ class SchemaFilesScanner : public SchemaScanner {
virtual ~SchemaFilesScanner();
virtual Status start(RuntimeState* state);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
##########
be/src/exec/schema_scanner/schema_columns_scanner.h:
##########
@@ -29,19 +29,18 @@ class SchemaColumnsScanner : public SchemaScanner {
SchemaColumnsScanner();
virtual ~SchemaColumnsScanner();
virtual Status start(RuntimeState* state);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
##########
be/src/exec/schema_scanner/schema_partitions_scanner.h:
##########
@@ -28,7 +28,7 @@ class SchemaPartitionsScanner : public SchemaScanner {
virtual ~SchemaPartitionsScanner();
virtual Status start(RuntimeState* state);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
##########
be/src/exec/schema_scanner/schema_dummy_scanner.h:
##########
@@ -26,7 +26,7 @@ class SchemaDummyScanner : public SchemaScanner {
SchemaDummyScanner();
virtual ~SchemaDummyScanner();
virtual Status start(RuntimeState* state = nullptr);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state = nullptr);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
##########
be/src/exec/schema_scanner/schema_table_privileges_scanner.h:
##########
@@ -28,14 +28,12 @@ class SchemaTablePrivilegesScanner : public SchemaScanner {
virtual ~SchemaTablePrivilegesScanner();
virtual Status start(RuntimeState* state);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
##########
be/src/exec/schema_scanner/schema_user_privileges_scanner.h:
##########
@@ -28,14 +28,12 @@ class SchemaUserPrivilegesScanner : public SchemaScanner {
virtual ~SchemaUserPrivilegesScanner();
virtual Status start(RuntimeState* state);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
##########
be/src/exec/schema_scanner/schema_views_scanner.h:
##########
@@ -28,14 +28,13 @@ class SchemaViewsScanner : public SchemaScanner {
virtual ~SchemaViewsScanner();
virtual Status start(RuntimeState* state);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
##########
be/src/exec/schema_scanner/schema_schemata_scanner.h:
##########
@@ -28,12 +28,11 @@ class SchemaSchemataScanner : public SchemaScanner {
virtual ~SchemaSchemataScanner();
virtual Status start(RuntimeState* state);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
##########
be/src/exec/schema_scanner/schema_variables_scanner.h:
##########
@@ -31,21 +31,20 @@ class SchemaVariablesScanner : public SchemaScanner {
virtual ~SchemaVariablesScanner();
virtual Status start(RuntimeState* state);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
##########
be/src/exec/schema_scanner/schema_schema_privileges_scanner.h:
##########
@@ -28,14 +28,12 @@ class SchemaSchemaPrivilegesScanner : public SchemaScanner {
virtual ~SchemaSchemaPrivilegesScanner();
virtual Status start(RuntimeState* state);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
