yiguolei commented on code in PR #15718:
URL: https://github.com/apache/doris/pull/15718#discussion_r1070201936


##########
be/src/exec/schema_scanner.cpp:
##########
@@ -231,4 +232,161 @@ Status SchemaScanner::create_tuple_desc(ObjectPool* pool) 
{
     return Status::OK();
 }
 
+Status SchemaScanner::fill_dest_column(vectorized::Block* block, void* data,
+                                       const SlotDescriptor* slot_desc) {
+    if (!block->has(slot_desc->col_name())) {
+        return Status::OK();
+    }
+    vectorized::IColumn* col_ptr = const_cast<vectorized::IColumn*>(

Review Comment:
   这里你不要直接使用裸指针, 尽量使用 ColumnPtr 这种类似智能指针的结构



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to