yiguolei commented on code in PR #64128:
URL: https://github.com/apache/doris/pull/64128#discussion_r3410719504
##########
be/src/exprs/bloom_filter_func_adaptor.h:
##########
@@ -80,11 +80,14 @@ class BloomFilterAdaptor : public FilterBase {
template <typename fixed_len_to_uint32_method, class T>
struct CommonFindOp {
- static uint16_t find_batch_olap_engine(const BloomFilterAdaptor&
bloom_filter, const char* data,
- const uint8_t* nullmap, uint16_t*
offsets, int number,
+ static uint16_t find_batch_olap_engine(const BloomFilterAdaptor&
bloom_filter,
+ const doris::IColumn& column, const
uint8_t* nullmap,
+ uint16_t* offsets, int number,
Review Comment:
这里加一个const expr 检查，这个T 不能是 stringref 或者string 之类的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
