Mryange commented on code in PR #64128:
URL: https://github.com/apache/doris/pull/64128#discussion_r3410681576
##########
be/src/storage/predicate/in_list_predicate.h:
##########
@@ -534,17 +536,12 @@ class InListPredicateBase final : public ColumnPredicate {
__builtin_unreachable();
}
} else {
- auto& pred_col =
- assert_cast<const
PredicateColumnType<PredicateEvaluateType<Type>>*>(column)
- ->get_data();
- auto pred_col_data = pred_col.data();
-
+ // ptr_at safe: HybridSet::find consumes the pointer synchronously.
Review Comment:
我们在string column view 里面存一个stringref就是因为这个代码吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
