csun5285 commented on code in PR #64128:
URL: https://github.com/apache/doris/pull/64128#discussion_r3410625497
##########
be/src/storage/predicate/comparison_predicate.h:
##########
@@ -554,10 +546,12 @@ class ComparisonPredicateBase final : public
ColumnPredicate {
}
}
+ // `data_array` is raw pointer or ColumnElementView wrapper; passed by
value
+ // (no __restrict on struct), SIMD preserved via loop versioning.
template <bool is_nullable, bool is_and, typename TArray, typename TValue>
void __attribute__((flatten))
_base_loop_vec(uint16_t size, bool* __restrict bflags, const uint8_t*
__restrict null_map,
- const TArray* __restrict data_array, const TValue& value)
const {
+ TArray data_array, const TValue& value) const {
Review Comment:
data_array 就是ColumnElementView，之前是一个数组，都是提供访问单个元素的能力。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
