yiguolei commented on code in PR #13487: URL: https://github.com/apache/doris/pull/13487#discussion_r1006471418
########## be/test/olap/rowset/segment_v2/bitmap_index_test.cpp: ########## @@ -35,6 +35,9 @@ #include "util/file_utils.h" namespace doris { + +using FileSystemPtr = std::shared_ptr<io::FileSystem>; Review Comment: if it is a shared ptr, then name it to FileSystemSPtr if it is a unique ptr, then name it to FileSystemUPtr then we could distinguish them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org