yiguolei commented on code in PR #13487: URL: https://github.com/apache/doris/pull/13487#discussion_r1006462262
########## be/src/io/fs/s3_file_system.h: ########## @@ -75,7 +75,8 @@ class S3FileSystem final : public RemoteFileSystem { // Guarded by external lock. void set_sk(std::string sk) { _s3_conf.sk = std::move(sk); } -private: + const S3Conf s3_conf() const { return _s3_conf; } Review Comment: This method is not used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org