yiguolei commented on code in PR #13487:
URL: https://github.com/apache/doris/pull/13487#discussion_r1006470133
##########
be/src/olap/tablet.cpp:
##########
@@ -1661,6 +1661,17 @@ Status Tablet::create_rowset_writer(const Version&
version, const RowsetStatePB&
TabletSchemaSPtr tablet_schema, int64_t
oldest_write_timestamp,
int64_t newest_write_timestamp,
std::unique_ptr<RowsetWriter>*
rowset_writer) {
+ return create_rowset_writer(version, rowset_state, overlap, tablet_schema,
+ oldest_write_timestamp,
newest_write_timestamp, nullptr, "",
+ rowset_writer);
+}
+
+Status Tablet::create_rowset_writer(const Version& version, const
RowsetStatePB& rowset_state,
+ const SegmentsOverlapPB& overlap,
+ TabletSchemaSPtr tablet_schema, int64_t
oldest_write_timestamp,
+ int64_t newest_write_timestamp,
io::FileSystemPtr fs,
+ const io::ResourceId& resource_id,
Review Comment:
could add an API resource_id() to filesystem iterface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
