englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r950037371
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJoin.java:
##########
@@ -43,7 +45,9 @@
extends LogicalBinary<LEFT_CHILD_TYPE, RIGHT_CHILD_TYPE> implements
Join {
private final JoinType joinType;
- private final Optional<Expression> condition;
+ private final Optional<Expression> otherJoinCondition;
+
+ private final List<Expression> hashJoinPredicates;
Review Comment:
As discussed in wechat group, `hashJoinPredicates` rename to
`hashJoinConjuncts`.
In next pr, `otherJoinCondition` will be renamed to `nonHashJoinConjuncts`
and change to List<Expression>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
