[GitHub] [doris] englefly commented on a diff in pull request #11812: [feature](Nereids) support non-equal predicates in Join

[GitBox]

englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r950121237


##########
fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/PlanEqualsTest.java:
##########
@@ -98,14 +99,18 @@ public void testLogicalJoin(@Mocked Plan left, @Mocked Plan 
right) {
                 new SlotReference("a", new BigIntType(), true, 
Lists.newArrayList()),
                 new SlotReference("b", new BigIntType(), true, 
Lists.newArrayList())
         );
-        LogicalJoin innerJoin1 = new LogicalJoin(JoinType.INNER_JOIN, 
Optional.of(condition1), left, right);
+        LogicalJoin innerJoin1 = new LogicalJoin(JoinType.INNER_JOIN, 
Lists.newArrayList(condition1),
+                Optional.empty(), left, right);
+        boolean bool = innerJoin1.equals(innerJoin);
+        System.out.println(bool);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org