englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r949948228
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/JoinLAsscomHelper.java:
##########
@@ -165,6 +166,7 @@ private Pair<List<NamedExpression>, List<NamedExpression>>
getProjectExprs() {
private LogicalJoin<GroupPlan, GroupPlan> newBottomJoin() {
return new LogicalJoin(
bottomJoin.getJoinType(),
+ bottomJoin.getHashJoinPredicates(),
Review Comment:
bottomJoin.getHashJoinPredicates() must be empty, because this rule is ahead
of FindHashConditionForJoin.
to make it more clear, I will use `ImmutableList.of()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
