englefly commented on code in PR #11812: URL: https://github.com/apache/doris/pull/11812#discussion_r949833624
########## fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java: ########## @@ -147,6 +148,7 @@ private void analyze() { private void rewrite() { new NormalizeExpressionRulesJob(cascadesContext).execute(); new JoinReorderRulesJob(cascadesContext).execute(); + new FindHashConditionForJoinJob(cascadesContext).execute(); Review Comment: in fact, this rule should be applied between ReorderJoin and PredicatePushDown. If we run ReorderJoin multiple times, we should run this rule multiple times. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org