yiguolei commented on code in PR #11869:
URL: https://github.com/apache/doris/pull/11869#discussion_r949895619
##########
be/src/olap/reader.h:
##########
@@ -201,10 +202,10 @@ class TabletReader {
std::vector<bool> _is_lower_keys_included;
std::vector<bool> _is_upper_keys_included;
// contains condition on key columns in agg or unique table or all column
in dup tables
- Conditions _conditions;
+ std::unique_ptr<Conditions> _conditions;
Review Comment:
because I change tablet schema as a parameter in Conditions constructor and
remove set tablet schema method because the condtion should always have a
tablet schema and should not be changed. But tablet schema is not required in
reader's constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
