HappenLee commented on code in PR #11869:
URL: https://github.com/apache/doris/pull/11869#discussion_r947867624
##########
be/src/olap/merger.cpp:
##########
@@ -108,14 +114,20 @@ Status Merger::vmerge_rowsets(TabletSharedPtr tablet,
ReaderType reader_type,
reader_params.reader_type = reader_type;
reader_params.rs_readers = src_rowset_readers;
reader_params.version = dst_rowset_writer->version();
- reader_params.tablet_schema = cur_tablet_schema;
{
std::shared_lock rdlock(tablet->get_header_lock());
std::copy(tablet->delete_predicates().cbegin(),
tablet->delete_predicates().cend(),
std::inserter(reader_params.delete_predicates,
reader_params.delete_predicates.begin()));
}
-
+ TabletSchemaSPtr merge_tablet_schema = std::make_shared<TabletSchema>();
Review Comment:
Don't repeat yourself. same as the line 50, maybe we need a function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
