HappenLee commented on code in PR #11869:
URL: https://github.com/apache/doris/pull/11869#discussion_r947873117
##########
be/src/olap/reader.cpp:
##########
@@ -498,15 +493,22 @@ ColumnPredicate* TabletReader::_parse_to_predicate(const
FunctionFilter& functio
function_filter._string_param);
}
-ColumnPredicate* TabletReader::_parse_to_predicate(const TCondition& condition,
+// This method is called in reader and in deletehandler.
+// When it is called by delete handler, then it should use the delete
predicate's tablet schema
+// to parse the conditions.
+ColumnPredicate* TabletReader::_parse_to_predicate(TabletSchemaSPtr
tablet_schema,
+ const TCondition& condition,
bool opposite) const {
- // TODO: not equal and not in predicate is not pushed down
- int32_t index = _tablet_schema->field_index(condition.column_name);
- if (index < 0) {
- return nullptr;
+ int32_t col_unique_id = -1;
+ // Delete handler will set column unique id to distinguish different
column with same name
Review Comment:
need more comment to know which case the if should be `true`
##########
be/src/olap/reader.h:
##########
@@ -201,10 +202,10 @@ class TabletReader {
std::vector<bool> _is_lower_keys_included;
std::vector<bool> _is_upper_keys_included;
// contains condition on key columns in agg or unique table or all column
in dup tables
- Conditions _conditions;
+ std::unique_ptr<Conditions> _conditions;
Review Comment:
why change unique_ptr， need more `malloc` operator
##########
be/src/olap/rowset/rowset_meta.h:
##########
@@ -233,8 +233,6 @@ class RowsetMeta {
bool delete_flag() const { return _rowset_meta_pb.delete_flag(); }
Review Comment:
this code useless also ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
