zhannngchen commented on code in PR #11830:
URL: https://github.com/apache/doris/pull/11830#discussion_r946553294


##########
be/src/olap/primary_key_index.cpp:
##########
@@ -70,6 +74,12 @@ Status PrimaryKeyIndexReader::parse(io::FileReaderSPtr 
file_reader,
     _index_reader.reset(new segment_v2::IndexedColumnReader(file_reader, 
meta.primary_key_index()));
     RETURN_IF_ERROR(_index_reader->load(!config::disable_storage_page_cache, 
false));
 
+    _parsed = true;

Review Comment:
   the `_parsed` variable should separate for pk_index and bf?
   e.g. in `check_present`, there is a `DCHECK(_parsed)`, then lookup bf, but 
`_parsed` can't guarantee the bf parsed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to