liaoxin01 commented on code in PR #11830:
URL: https://github.com/apache/doris/pull/11830#discussion_r946547664
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -522,6 +522,13 @@ Status
SegmentIterator::_lookup_ordinal_from_pk_index(const RowCursor& key, bool
std::string index_key;
encode_key_with_padding<RowCursor, true, true>(
&index_key, key, _segment->_tablet_schema->num_key_columns(),
is_include);
+ if (index_key <= _segment->min_key()) {
Review Comment:
we should detect `is_include` condition when equal.
##########
be/src/olap/primary_key_index.h:
##########
@@ -71,6 +71,8 @@ class PrimaryKeyIndexReader {
Status parse(io::FileReaderSPtr file_reader, const
segment_v2::PrimaryKeyIndexMetaPB& meta);
Review Comment:
rename to `parse_index`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
