yixiutt commented on code in PR #11830:
URL: https://github.com/apache/doris/pull/11830#discussion_r946540189
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -226,8 +226,8 @@ Status SegmentIterator::_get_row_ranges_by_keys() {
// If client want to read upper_bound, the include_upper is true.
So we
// should get the first ordinal at which key is larger than
upper_bound.
// So we call _lookup_ordinal with include_upper's negate
- RETURN_IF_ERROR(_lookup_ordinal(*key_range.upper_key,
!key_range.include_upper,
- num_rows(), &upper_rowid));
+ RETURN_IF_ERROR(_lookup_ordinal(*key_range.lower_key,
key_range.include_lower,
Review Comment:
fixed
##########
be/src/olap/tablet.cpp:
##########
@@ -1937,7 +1937,7 @@ Status Tablet::calc_delete_bitmap(RowsetId rowset_id,
int64_t end_version = max_version_unlocked().second;
Version dummy_version(end_version + 1, end_version + 1);
for (auto& seg : segments) {
- seg->load_index(); // We need index blocks to iterate
+ seg->load_pk_index_and_bf(); // We need index blocks to iterate
Review Comment:
need load bf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
