gavinchou commented on code in PR #51448:
URL: https://github.com/apache/doris/pull/51448#discussion_r2139360003
##########
cloud/src/recycler/recycler.h:
##########
@@ -165,15 +165,24 @@ class InstanceRecycler {
* @param is_empty_tablet indicates whether the tablet has object files,
can skip delete objects if tablet is empty
* @return 0 for success otherwise error
*/
- int recycle_tablets(int64_t table_id, int64_t index_id, int64_t
partition_id = -1,
+ int recycle_tablets(int64_t table_id, int64_t index_id, int64_t&
total_need_recycle_data_size,
+ std::atomic_long& total_recycle_data_size, int64_t
partition_id = -1,
bool is_empty_tablet = false);
/**
* recycle all rowsets belonging to the tablet specified by `tablet_id`
*
* @return 0 for success otherwise error
*/
- int recycle_tablet(int64_t tablet_id);
+ int recycle_tablet(int64_t tablet_id, bool is_recycle_partition_tablet,
+ int64_t& total_need_recycle_data_size,
+ std::atomic_long& total_recycle_data_size);
+
+ int scan_tablets_and_statistics(int64_t tablet_id, int64_t index_id,
Review Comment:
scan_tablets_and_statistics 和 scan_tablet_and_statistics 有什么区别,
这两个函数是用来做什么的 参数是什么意思 写清楚 注释.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
