gavinchou commented on code in PR #51448:
URL: https://github.com/apache/doris/pull/51448#discussion_r2139361111


##########
cloud/src/recycler/recycler.h:
##########
@@ -227,8 +236,11 @@ class InstanceRecycler {
                            const std::string& rowset_id);
 
     // return 0 for success otherwise error
-    int delete_rowset_data(const std::vector<doris::RowsetMetaCloudPB>& 
rowsets,
-                           RowsetRecyclingState type);
+    int delete_rowset_data(const std::map<std::string, 
doris::RowsetMetaCloudPB>& rowsets,

Review Comment:
   传递上下文 不传递具体的单个值
   考虑结构体复用.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to