gavinchou commented on code in PR #51448:
URL: https://github.com/apache/doris/pull/51448#discussion_r2139358471
##########
cloud/src/recycler/recycler.h:
##########
@@ -165,15 +165,24 @@ class InstanceRecycler {
* @param is_empty_tablet indicates whether the tablet has object files,
can skip delete objects if tablet is empty
* @return 0 for success otherwise error
*/
- int recycle_tablets(int64_t table_id, int64_t index_id, int64_t
partition_id = -1,
+ int recycle_tablets(int64_t table_id, int64_t index_id, int64_t&
total_need_recycle_data_size,
Review Comment:
`total_need_recycle_data_size` 不要一个一个变量传递,
做成上下文传递 除了 data_size 还有 rowset 个数 segement, 原因 时间等 会有很多需要统计的信息.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
