924060929 commented on code in PR #10241:
URL: https://github.com/apache/doris/pull/10241#discussion_r901277729
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Expression.java:
##########
@@ -18,18 +18,22 @@
package org.apache.doris.nereids.trees.expressions;
import org.apache.doris.nereids.exceptions.UnboundException;
-import org.apache.doris.nereids.rules.expression.rewrite.ExpressionVisitor;
import org.apache.doris.nereids.trees.AbstractTreeNode;
import org.apache.doris.nereids.trees.NodeType;
import org.apache.doris.nereids.types.DataType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import java.util.List;
/**
* Abstract class for all Expression in Nereids.
*/
public abstract class Expression extends AbstractTreeNode<Expression> {
+ private final Logger logger = LoggerFactory.getLogger(this.getClass());
Review Comment:
static logger can not save the real child class instance for log.
for example, EqualTo is the child class of Expression.
if the logger is static, the log is ' 2022-06-20 14:02:00.123 WARN
(Expression) - xxxx'
but we need the concrete class in the log: ' 2022-06-20 14:02:00.123 WARN
(EqualTo) - xxxx'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
