924060929 commented on code in PR #10241: URL: https://github.com/apache/doris/pull/10241#discussion_r901278864
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Expression.java: ########## @@ -18,18 +18,22 @@ package org.apache.doris.nereids.trees.expressions; import org.apache.doris.nereids.exceptions.UnboundException; -import org.apache.doris.nereids.rules.expression.rewrite.ExpressionVisitor; import org.apache.doris.nereids.trees.AbstractTreeNode; import org.apache.doris.nereids.trees.NodeType; import org.apache.doris.nereids.types.DataType; +import org.slf4j.Logger; Review Comment: use interface is more flexible and reasonable then a concrete implement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
