924060929 commented on code in PR #10241:
URL: https://github.com/apache/doris/pull/10241#discussion_r901273524
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -54,11 +56,14 @@ public Group getRoot() {
* @param rewrite whether to rewrite the node to the target group
* @return Reference of node in Memo
*/
- public GroupExpression copyIn(Plan node, Group target, boolean rewrite) {
- Preconditions.checkArgument(!rewrite || target != null);
Review Comment:
this line will cause a bug: rewrite could create multi hierarchy, for
example new LogicalFilter(new LogicalRelation). the child(LogicalRelation) need
be rewrite(insert or update into memo), bug target Group not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
