yiguolei commented on code in PR #45614:
URL: https://github.com/apache/doris/pull/45614#discussion_r1891581255
##########
be/src/pipeline/task_queue.h:
##########
@@ -112,25 +112,27 @@ class MultiCoreTaskQueue {
void close();
// Get the task by core id.
- PipelineTask* take(int core_id);
+ std::shared_ptr<PipelineTask> take(int core_id);
// TODO combine these methods to `push_back(task, core_id = -1)`
- Status push_back(PipelineTask* task);
+ Status push_back(std::shared_ptr<PipelineTask> task, bool eager = false);
- Status push_back(PipelineTask* task, int core_id);
+ Status push_back(std::shared_ptr<PipelineTask>& task, int core_id);
void update_statistics(PipelineTask* task, int64_t time_spent);
- int cores() const { return _core_size; }
+ int num_queues() const { return cast_set<int>(_prio_task_queues.size()); }
+ int eager_queue_idx() const { return _eager_queue_idx; }
private:
- PipelineTask* _steal_take(int core_id);
+ std::shared_ptr<PipelineTask> _steal_take(int core_id);
std::vector<PriorityTaskQueue> _prio_task_queues;
std::atomic<uint32_t> _next_core = 0;
std::atomic<bool> _closed;
- int _core_size;
+ const int _core_size;
+ const int _eager_queue_idx;
Review Comment:
_urgent_queue_idx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
