github-actions[bot] commented on code in PR #45614:
URL: https://github.com/apache/doris/pull/45614#discussion_r1893343598
##########
be/src/pipeline/task_queue.cpp:
##########
@@ -172,7 +178,7 @@ PipelineTask* MultiCoreTaskQueue::take(int core_id) {
return task;
}
-PipelineTask* MultiCoreTaskQueue::_steal_take(int core_id) {
+std::shared_ptr<PipelineTask> MultiCoreTaskQueue::_steal_take(int core_id) {
Review Comment:
warning: method '_steal_take' can be made const
[readability-make-member-function-const]
```suggestion
std::shared_ptr<PipelineTask> MultiCoreTaskQueue::_steal_take(int core_id)
const {
```
be/src/pipeline/task_queue.h:126:
```diff
- std::shared_ptr<PipelineTask> _steal_take(int core_id);
+ std::shared_ptr<PipelineTask> _steal_take(int core_id) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
