yiguolei commented on code in PR #45614:
URL: https://github.com/apache/doris/pull/45614#discussion_r1891573087
##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -554,10 +555,40 @@ std::string PipelineTask::debug_string() {
void PipelineTask::wake_up() {
// call by dependency
- static_cast<void>(get_task_queue()->push_back(this));
+ static_cast<void>(
+ get_task_queue()->push_back(shared_from_this(),
query_context()->is_cancelled()));
+}
+
+void PipelineTask::clear_blocking_state(bool cancel) {
+ _state->get_query_ctx()->get_execution_dependency()->set_always_ready();
+ // We use a lock to assure all dependencies are not deconstructed here.
+ std::unique_lock<std::mutex> lc(_dependency_lock);
+ if (!_finalized) {
+ if (cancel) {
+ DCHECK(query_context()->is_cancelled());
+ wake_up();
Review Comment:
为什么要在这里手动调用wakeup？
我看后续的set always ready 也会调用wake up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
