zclllyybb commented on code in PR #42344: URL: https://github.com/apache/doris/pull/42344#discussion_r1855406295
########## be/src/common/exception.cpp: ########## @@ -29,7 +29,8 @@ Exception::Exception(int code, const std::string_view& msg) { _err_msg->_stack = get_stack_trace(); } if (config::exit_on_exception) { - LOG(FATAL) << "[ExitOnException] error code: " << code << ", message: " << msg; + throw Exception( Review Comment: dont change this. we want always exit on exception here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org