zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1852664085
##########
be/src/olap/comparison_predicate.h:
##########
@@ -524,7 +526,7 @@ class ComparisonPredicateBase : public ColumnPredicate {
_base_loop_bit<is_nullable, is_and>(sel, size, flags,
null_map, data_array,
dict_code);
} else {
- LOG(FATAL) << "column_dictionary must use StringRef
predicate.";
+ static_assert(!std::is_same_v<T, StringRef>,
"column_dictionary must use StringRef predicate.");
Review Comment:
we wrote `if constexpr (std::is_same_v<T, StringRef>)` upon
so here going into `else` means `T` is **not same** with `StringRef`. we
want a failure here. so I think we should assert `std::is_same_v<T,
StringRef>`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
