github-actions[bot] commented on code in PR #42344: URL: https://github.com/apache/doris/pull/42344#discussion_r1851557930
########## be/src/gutil/strings/numbers.cc: ########## @@ -10,15 +10,18 @@ #include <ctype.h> #include <errno.h> #include <float.h> // for DBL_DIG and FLT_DIG -#include <math.h> // for HUGE_VAL +#include <inttypes.h> +#include <math.h> // for HUGE_VAL Review Comment: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers] ```suggestion #include <cmath> // for HUGE_VAL ``` ########## be/src/gutil/strings/numbers.cc: ########## @@ -10,15 +10,18 @@ #include <ctype.h> #include <errno.h> #include <float.h> // for DBL_DIG and FLT_DIG -#include <math.h> // for HUGE_VAL +#include <inttypes.h> Review Comment: warning: inclusion of deprecated C++ header 'inttypes.h'; consider using 'cinttypes' instead [modernize-deprecated-headers] ```suggestion #include <cinttypes> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
