yiguolei commented on code in PR #39497:
URL: https://github.com/apache/doris/pull/39497#discussion_r1721619456
##########
be/src/olap/accept_null_predicate.h:
##########
@@ -77,20 +79,7 @@ class AcceptNullPredicate : public ColumnPredicate {
void evaluate_or(const vectorized::IColumn& column, const uint16_t* sel,
uint16_t size,
bool* flags) const override {
- if (column.has_null()) {
- const auto& nullable_col = assert_cast<const
vectorized::ColumnNullable&>(column);
- _nested->evaluate_or(nullable_col.get_nested_column(), sel, size,
flags);
-
- // call evaluate_or and set true for NULL rows
- for (uint16_t i = 0; i < size; ++i) {
- uint16_t idx = sel[i];
- if (!flags[i] && nullable_col.is_null_at(idx)) {
- flags[i] = true;
- }
- }
- } else {
- _nested->evaluate_or(column, sel, size, flags);
- }
+ DCHECK(false) << "should not reach here";
Review Comment:
直接用check，保证线上数据别出错，或者throw exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
